Sites in a subdirectory produce an error when donating via VFB forms#28

In subdirectory WP installations, VFB forms return an Invalid Form ID error and fail to record the donation in the backend.

User identified this as a URL construction issue for missing a / at the end of the home_url(). Line they’re referring to: [https://github.com/impress-org/givewp/blob/develop/src/Framework/Routes/Router.php#L136|https://github.com/impress-org/givewp/blob/develop/src/Framework/Routes/Router.php#L136|smart-link]

Robin Joshua Del Mundo Apr 9th at 3:05 PM

I managed to test this solution on a test site in a subdirectory installation, and it looks to be a quick solution as we only need to edit one line. So far, I don’t see any kind of ramifications.

Steps to replicate:

Install WordPress and GiveWP on a Subdirectory.
Create a VFB Form.
In a multistep or two panel template, the form will not move after the first step (after the header).
In a classic form template, the donation will not submit.

Changing this line [https://github.com/impress-org/givewp/blob/develop/src/Framework/Routes/Router.php#L136|https://github.com/impress-org/givewp/blob/develop/src/Framework/Routes/Router.php#L136|smart-link] , from home_url() _to_ rtrim(home_url(), '/').'/' resolves the issue.

Reference